[webkit-reviews] review requested: [Bug 84137] [GTK] Properly expose <legend> elements to ATs : [Attachment 161155] proposed patch

[bugzilla-daemon at webkit.org]

Joanmarie Diggs <jdiggs at igalia.com> has asked  for review:
Bug 84137: [GTK] Properly expose <legend> elements to ATs
https://bugs.webkit.org/show_bug.cgi?id=84137

Attachment 161155: proposed patch
https://bugs.webkit.org/attachment.cgi?id=161155&action=review

------- Additional Comments from Joanmarie Diggs <jdiggs at igalia.com>
* Created a new WebCore Accessibility Role, LegendRole.
* Used it to map to the expected platform role, ATK_ROLE_LABEL.
* Established the needed AtkRelation pair, label-for/labelled-by
  between the legend and fieldset.
* Modified legend.html to use buildAccessibilityTree() [1]
* Unskipped legend.html for Gtk.
* Added expected results for Gtk.
* Updated expected results for Mac because the output from
  buildAccessibilityTree() changes the appearance.

Please review.

[1] It's in three tests already so why not four? ;) Note that I did open bug
95286 because this handy function should be somewhere other than individual
tests. Chris gave me some advice as to how. (Thanks!) So I'll give that a shot.
In the meantime, if we can overlook the duplication I'd appreciate it.