[webkit-reviews] review granted: [Bug 95248] AX: Canvas should have a distinct role : [Attachment 161076] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 28 22:35:14 PDT 2012
chris fleizach <cfleizach at apple.com> has granted Dominic Mazzoni
<dmazzoni at google.com>'s request for review:
Bug 95248: AX: Canvas should have a distinct role
https://bugs.webkit.org/show_bug.cgi?id=95248
Attachment 161076: Patch
https://bugs.webkit.org/attachment.cgi?id=161076&action=review
------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=161076&action=review
just one question inline. otherwise looks good
> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:318
> + Element* element = toElement(node);
it doesn't appear that you need to case to Element in this case
More information about the webkit-reviews
mailing list