[webkit-reviews] review granted: [Bug 40272] The 2d.imageData.object.round canvas test is failing : [Attachment 160924] Boundaries and zero tests, Assertion added.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 28 22:37:46 PDT 2012


Benjamin Poulain <benjamin at webkit.org> has granted Dominik Röttsches (drott)
<dominik.rottsches at intel.com>'s request for review:
Bug 40272: The 2d.imageData.object.round canvas test is failing
https://bugs.webkit.org/show_bug.cgi?id=40272

Attachment 160924: Boundaries and zero tests, Assertion added.
https://bugs.webkit.org/attachment.cgi?id=160924&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160924&action=review


This patch looks correct and well tested, r+.

Just a tiny change in TestWebKitAPI.xcodeproj to make the merges easier:

> Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:987
> +				B4039F9D15E6D8B3007255D6 /* MathExtras.cpp in
Sources */,

This is the build section of the xcodeproject file. Please keep this region
sorted (you can edit that part as text).


More information about the webkit-reviews mailing list