[webkit-reviews] review granted: [Bug 95104] [webkit-patch] Don't crash chrome-channels command when a previously unknown platform shows up. : [Attachment 160748] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 27 12:02:24 PDT 2012
Adam Barth <abarth at webkit.org> has granted Gavin Peters <gavinp at chromium.org>'s
request for review:
Bug 95104: [webkit-patch] Don't crash chrome-channels command when a previously
unknown platform shows up.
https://bugs.webkit.org/show_bug.cgi?id=95104
Attachment 160748: Patch
https://bugs.webkit.org/attachment.cgi?id=160748&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160748&action=review
> Tools/Scripts/webkitpy/common/net/omahaproxy.py:71
> + pretty_platform = self.chrome_platforms[platform["os"]]
if platform["os"] in self.chrome_platforms else platform["os"]
self.chrome_platforms.get(platform["os"], platform["os"])
More information about the webkit-reviews
mailing list