[webkit-reviews] review granted: [Bug 95091] Web Inspector: persist the state of glue records to parents button of Timeline panel : [Attachment 160732] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 27 12:01:46 PDT 2012


Vsevolod Vlasov <vsevik at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 95091: Web Inspector: persist the state of glue records to parents button
of Timeline panel
https://bugs.webkit.org/show_bug.cgi?id=95091

Attachment 160732: Patch
https://bugs.webkit.org/attachment.cgi?id=160732&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160732&action=review


> Source/WebCore/inspector/front-end/TimelinePanel.js:545
> +	   this._presentationModel.setGlueRecords(newValue);

I am not sure which one is correct, but previously you were setting !newValue
to presentation model's glue records flag.


More information about the webkit-reviews mailing list