[webkit-reviews] review granted: [Bug 94395] [Chrome] Create a toggle button for closed captions : [Attachment 160487] minor revisions

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Anna Cavender
<annacc at chromium.org>'s request for review:
Bug 94395: [Chrome] Create a toggle button for closed captions
https://bugs.webkit.org/show_bug.cgi?id=94395

Attachment 160487: minor revisions
https://bugs.webkit.org/attachment.cgi?id=160487&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=160487&action=review


r+, although you will clearly have to figure why the test is failing.

> Source/WebCore/html/HTMLMediaElement.cpp:3963
> +	   // Mark all track elements as not "configured" so that
configureTextTracks()
> +	   // will reconsider which tracks to display in light of new user
preferences
> +	   // (e.g. default tracks should not be displayed if the user has
turned off
> +	   // captions and non-default tracks should be displayed based on
language
> +	   // preferences if the user has turned captions on).

Nice explanation, thanks!