[webkit-reviews] review granted: [Bug 85050] TextTrack modes are strings : [Attachment 160519] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Anna Cavender
<annacc at chromium.org>'s request for review:
Bug 85050: TextTrack modes are strings
https://bugs.webkit.org/show_bug.cgi?id=85050

Attachment 160519: Patch
https://bugs.webkit.org/attachment.cgi?id=160519&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=160519&action=review


> Source/WebCore/ChangeLog:18
> +	   * html/HTMLMediaElement.cpp:
> +	   (WebCore::HTMLMediaElement::loadInternal):
> +	   (WebCore::HTMLMediaElement::textTrackModeChanged):
> +	   (WebCore::HTMLMediaElement::textTrackKindChanged):
> +	   (WebCore::HTMLMediaElement::addTextTrack):

I think it is helpful to have a brief explanation of what changed in each
method.