[webkit-reviews] review granted: [Bug 94826] Web Inspector: dblclick on Timeline overview no longer selects entire timeline range : [Attachment 160191] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 23 10:30:21 PDT 2012


Vsevolod Vlasov <vsevik at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 94826: Web Inspector: dblclick on Timeline overview no longer selects
entire timeline range
https://bugs.webkit.org/show_bug.cgi?id=94826

Attachment 160191: Patch
https://bugs.webkit.org/attachment.cgi?id=160191&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160191&action=review


> Source/WebCore/inspector/front-end/UIUtils.js:69
> +    function onMouseOut()

WebInspector._mouseOutWhileDragging = function()... ?

> Source/WebCore/inspector/front-end/UIUtils.js:71
> +	   targetDocument.removeEventListener("mouseout", onMouseOut, true);

I would extract removeEventListener and delete statement.


More information about the webkit-reviews mailing list