[webkit-reviews] review granted: [Bug 94807] Flexbox doesn't need to compute logical height for stretched items in row flow : [Attachment 160173] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Shezan Baig
<shezbaig.wk at gmail.com>'s request for review:
Bug 94807: Flexbox doesn't need to compute logical height for stretched items
in row flow
https://bugs.webkit.org/show_bug.cgi?id=94807

Attachment 160173: Patch
https://bugs.webkit.org/attachment.cgi?id=160173&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=160173&action=review


> Source/WebCore/rendering/RenderBox.cpp:443
>      if (maxH == -1)
> -	   maxH = result;
> -    result = min(maxH, result);
> -    result = max(minH, result);
> -    return result;
> +	   maxH = logicalHeight;
> +    logicalHeight = min(maxH, logicalHeight);

Nit: This could just be:
if (maxH != -1)
    logicalHeight = min(maxH, logicalHeight);