[webkit-reviews] review denied: [Bug 84582] webkitpy: changelog crashes when parsing authors containing + or , : [Attachment 138318] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 22 15:38:52 PDT 2012
Ryosuke Niwa <rniwa at webkit.org> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 84582: webkitpy: changelog crashes when parsing authors containing + or ,
https://bugs.webkit.org/show_bug.cgi?id=84582
Attachment 138318: Patch
https://bugs.webkit.org/attachment.cgi?id=138318&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138318&action=review
> Tools/Scripts/webkitpy/common/checkout/changelog.py:-154
> - authors = ChangeLogEntry._split_contributor_names(text)
I don't think we want to duplicate reg exps here.
More information about the webkit-reviews
mailing list