[webkit-reviews] review granted: [Bug 94653] IndexedDB: tests for injection/extraction of idb keys : [Attachment 159999] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 22 15:38:21 PDT 2012


Tony Chang <tony at chromium.org> has granted Alec Flett
<alecflett at chromium.org>'s request for review:
Bug 94653: IndexedDB: tests for injection/extraction of idb keys
https://bugs.webkit.org/show_bug.cgi?id=94653

Attachment 159999: Patch
https://bugs.webkit.org/attachment.cgi?id=159999&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159999&action=review


> Source/WebKit/chromium/tests/IDBKeyPathTest.cpp:190
> +    const UChar expectedData[] = {0x01ff, 0x003f, 0x3f6f, 0x5301, 0x6603,
> +				      0x6f6f, 0x013f, 0x0353, 0x6f7a, 0x3f6f,

Nit: Indent is weird.

> Source/WebKit/chromium/tests/IDBKeyPathTest.cpp:205
> +    const UChar expectedData2[] = {0x01ff, 0x003f, 0x3f6f, 0x5301, 0x6603,
> +				       0x6f6f, 0x013f, 0x0353, 0x6f7a, 0x3f6f,

Nit: ditto


More information about the webkit-reviews mailing list