[webkit-reviews] review requested: [Bug 93665] Class attribute logic needs to be moved to Element (from StyledElement) : [Attachment 159983] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has asked  for review:
Bug 93665: Class attribute logic needs to be moved to Element (from
StyledElement)
https://bugs.webkit.org/show_bug.cgi?id=93665

Attachment 159983: Patch
https://bugs.webkit.org/attachment.cgi?id=159983&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159983&action=review


> Source/WebCore/ChangeLog:9
> +	   Class attribute logic needs to be moved to Element (from
StyledElement)
> +	   https://bugs.webkit.org/show_bug.cgi?id=93665
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Before this change classAttributeChanged was only called for
StyledElement. With this refactoring
> +	   it gets called for all Elements when the class attribute changes.

Does this fix some bug or is it just a refactoring? Please clarify.
Ideally the bug title is changed to reflect whatever behavior being fixed if
there is any behavior change.

> Source/WebCore/dom/ClassNodeList.cpp:57
> +    // TODO: DOM4 allows getElementsByClassName to return non StyledElement.


We use FIXME instead of TODO.