[webkit-reviews] review granted: [Bug 93119] MediaStream API: Introduce RTCSessionDescription : [Attachment 159911] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 93119: MediaStream API: Introduce RTCSessionDescription
https://bugs.webkit.org/show_bug.cgi?id=93119

Attachment 159911: Patch
https://bugs.webkit.org/attachment.cgi?id=159911&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159911&action=review


> Source/WebCore/Modules/mediastream/RTCSessionDescription.cpp:59
> +    if (!ok || !sdp.length()) {

!sdp.length() -> sdp.isEmpty()

Would you be willing to post a follow-up patch with this tweak?

> Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h:51
> +    const String& type() { return m_type; }
> +    void setType(const String& type) { m_type = type; }
> +
> +    const String& sdp() { return m_sdp; }
> +    void setSdp(const String& sdp) { m_sdp = sdp; }

ekr points out that these could be const.  We typically don't worry too much
about const-correctness, but it's a nice-to-have.