[webkit-reviews] review denied: [Bug 94493] [JSC] SerializedScriptValue::create() should throw a DataCloneError if input is an unsupported native object : [Attachment 159476] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 20 11:13:33 PDT 2012


Oliver Hunt <oliver at apple.com> has denied Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 94493: [JSC] SerializedScriptValue::create() should throw a DataCloneError
if input is an unsupported native object
https://bugs.webkit.org/show_bug.cgi?id=94493

Attachment 159476: Patch
https://bugs.webkit.org/attachment.cgi?id=159476&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=159476&action=review


> Source/WebCore/bindings/js/SerializedScriptValue.cpp:688
>	       if (getCallData(value, unusedData) == CallTypeNone)

This is the function check here -- if the call type is not CallTypeNone then
whatever object we are dealing with is a functino of some kind.


More information about the webkit-reviews mailing list