[webkit-reviews] review granted: [Bug 94450] [V8] Remove V8Proxy from V8IsolatedContext : [Attachment 159352] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 94450: [V8] Remove V8Proxy from V8IsolatedContext
https://bugs.webkit.org/show_bug.cgi?id=94450

Attachment 159352: Patch
https://bugs.webkit.org/attachment.cgi?id=159352&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159352&action=review


>> Source/WebCore/bindings/v8/ScriptController.cpp:198
>> -		    isolatedContext = new V8IsolatedContext(proxy(),
extensionGroup, worldID);
>> +		    isolatedContext = new V8IsolatedContext(m_frame,
extensionGroup, worldID);
> 
> Should V8IsolatedContext be a RefPtr? If so, I'll write a follow-up fix to
make it reference-countable.

Its lifetime is managed by the V8 garbage collector.  If you see a clean way to
do that with RefPtr, go for it.