[webkit-reviews] review granted: [Bug 94446] [V8] Move contextDebugId() and setContextDebugId() from V8Proxy to ScriptController : [Attachment 159338] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 94446: [V8] Move contextDebugId() and setContextDebugId() from V8Proxy to
ScriptController
https://bugs.webkit.org/show_bug.cgi?id=94446

Attachment 159338: Patch
https://bugs.webkit.org/attachment.cgi?id=159338&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159338&action=review


This code is kind of nuts.

> Source/WebCore/bindings/v8/ScriptController.cpp:532
> +    char buffer[32];
> +    snprintf(buffer, sizeof(buffer), "page,%d", debugId);

Can you add buffer[31] = '\0' ?

> Source/WebCore/bindings/v8/V8IsolatedContext.cpp:85
>      // Setup context id for JS debugger.

I'd remove this comment.