[webkit-reviews] review granted: [Bug 94422] Web Inspector: toolbar causes 8 reflows upon opening : [Attachment 159281] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 94422: Web Inspector: toolbar causes 8 reflows upon opening
https://bugs.webkit.org/show_bug.cgi?id=94422

Attachment 159281: Patch
https://bugs.webkit.org/attachment.cgi?id=159281&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159281&action=review


> Source/WebCore/inspector/front-end/Toolbar.js:55
> +	   if (!this._coalescingLevel)

No need to check it here.

> Source/WebCore/inspector/front-end/inspector.js:519
> +    this.toolbar.setCoalescingUpdate(true);

Consider changing addPanel() to addPanels() that would encapsulate this
optimization for batch mode or pass the batchMode flag as an explicit parameter
to addPanel.