[webkit-reviews] review denied: [Bug 94196] [Tests] Adding tests for multiple fields time input UI : [Attachment 158989] Patch 5

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 94196: [Tests] Adding tests for multiple fields time input UI
https://bugs.webkit.org/show_bug.cgi?id=94196

Attachment 158989: Patch 5
https://bugs.webkit.org/attachment.cgi?id=158989&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158989&action=review


>
LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-change-type-on
-focus-expected.txt:1
> +Bug 46950: Assertion failure by changing type from type=time in focus event.


Bug 46950 is unrelated to type=time.

>
LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-keyboard-event
s.html:46
> +beginTest('Digit keys');
> +keyDown('7');
> +keyDown('5');
> +keyDown('6');
> +keyDown('A');
> +shouldBeEqualToString('input.value', '07:56');

We should test typeAheadTimeout behavior. You can use
eventSender.leapForward().