[webkit-reviews] review denied: [Bug 94290] [WIP] Pre-process CSSGrammar.y before running through bison. : [Attachment 158988] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 16 21:28:14 PDT 2012


Tony Chang <tony at chromium.org> has denied Shane Stephens
<shanestephens at google.com>'s request for review:
Bug 94290: [WIP] Pre-process CSSGrammar.y before running through bison.
https://bugs.webkit.org/show_bug.cgi?id=94290

Attachment 158988: Patch
https://bugs.webkit.org/attachment.cgi?id=158988&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158988&action=review


> Source/WebCore/ChangeLog:8
> +	   * DerivedSources.make:

Chromium doens't use DerivedSources.make.  You'll have to update
WebCore.gyp/Webcore.gyp too.

> Source/WebCore/ChangeLog:11
> +	   * css/makegrammar.pl:

Did you mean to include makegrammar.pl here? I don't see any changes to this
file.


More information about the webkit-reviews mailing list