[webkit-reviews] review denied: [Bug 94122] win64 compile error fix for BinaryPropertyList.cpp : [Attachment 158589] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Alex Christensen
<alex.christensen at flexsim.com>'s request for review:
Bug 94122: win64 compile error fix for BinaryPropertyList.cpp
https://bugs.webkit.org/show_bug.cgi?id=94122

Attachment 158589: Patch
https://bugs.webkit.org/attachment.cgi?id=158589&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158589&action=review


I think the intent of this change is good, but please switch to the more
explicit C++-style cast; I think this is just a static_cast<>.

> Source/WebCore/platform/cf/BinaryPropertyList.cpp:700
> +	       appendByte((unsigned char)(asciiStringMarkerByte | length));

We use C++-style casts in the Coding Guideline:

static_cast<unsigned char>(asciiStringMarkerByte | length)

> Source/WebCore/platform/cf/BinaryPropertyList.cpp:709
> +	       appendByte((unsigned char)(unicodeStringMarkerByte | length));

Ditto.

> Source/WebCore/platform/cf/BinaryPropertyList.cpp:726
> +	   appendByte((unsigned char)(asciiStringMarkerByte | length));

Ditto