[webkit-reviews] review denied: [Bug 94124] clipboardwin compile error for win64 : [Attachment 158592] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Alex Christensen
<alex.christensen at flexsim.com>'s request for review:
Bug 94124: clipboardwin compile error for win64
https://bugs.webkit.org/show_bug.cgi?id=94124

Attachment 158592: Patch
https://bugs.webkit.org/attachment.cgi?id=158592&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158592&action=review


Looks fine to me (and the EWS).  Please revise the ChangeLog notes and I think
we are ready to land/

> Source/WebCore/ChangeLog:5
> +

I think you should include your helpful explanation here:

"The clipboard utilities code uses std::min with one unsigned int parameter and
one size_t parameter. This causes a problem when compiling for 64-bit windows
because the two types are not the same size.  To resolve this issue, we specify
the template type as the type the return value is being cast into."