[webkit-reviews] review granted: [Bug 92471] ASSERTION FAILED: allocatedMaxLogicalWidth <= cellMaxLogicalWidth : int WebCore::AutoTableLayout::calcEffectiveLogicalWidth() : [Attachment 158324] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Arpita Bahuguna
<arpitabahuguna at gmail.com>'s request for review:
Bug 92471: ASSERTION FAILED: allocatedMaxLogicalWidth <= cellMaxLogicalWidth :
int WebCore::AutoTableLayout::calcEffectiveLogicalWidth()
https://bugs.webkit.org/show_bug.cgi?id=92471

Attachment 158324: Patch
https://bugs.webkit.org/attachment.cgi?id=158324&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
> Won’t this reintroduce bug 15010 or similar bugs?

AFAICT the test added in this bug passes so at least this overflow doesn't
happen. Considering our bad coverage, it doesn't mean we don't have other
overflows.

I believe this patch makes a good attempt at addressing the original overflow
issue but without being involved in it, this is guess-work. I intent to let
this patch land tomorrow as-is. Dan, feel free to override the decision.