[webkit-reviews] review granted: [Bug 94129] Mark Skia and Compositor Contexts : [Attachment 158602] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 15 11:27:46 PDT 2012
James Robinson <jamesr at chromium.org> has granted Gregg Tavares
<gman at google.com>'s request for review:
Bug 94129: Mark Skia and Compositor Contexts
https://bugs.webkit.org/show_bug.cgi?id=94129
Attachment 158602: Patch
https://bugs.webkit.org/attachment.cgi?id=158602&action=review
------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158602&action=review
Do you have to pop these markers ever?
> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:694
> + context3d->pushGroupMarkerEXT("CompositorContext");
This would be better in LayerRendererChromium::initialize() - all WGC3D stuff
should be down there.
More information about the webkit-reviews
mailing list