[webkit-reviews] review denied: [Bug 93866] [BlackBerry] Queue spellcheck requests with char-count limitations : [Attachment 158335] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Nima Ghanavatian
<nima.ghanavatian at gmail.com>'s request for review:
Bug 93866: [BlackBerry] Queue spellcheck requests with char-count limitations
https://bugs.webkit.org/show_bug.cgi?id=93866

Attachment 158335: Patch
https://bugs.webkit.org/attachment.cgi?id=158335&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=158335&action=review


Looks good, some minor issues to fix.

> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:789
> +    BlackBerry::Platform::StopWatch m_timer;

We generally do not use m_ for static local vars.

> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:796
> +    Frame* frame = element->document()->frame();

Could element->document() be null?

> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:857
> +	   // If total block text is under the limitted amount, send the entire
chunk.

limited I think.

> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:899
> +    RefPtr<Range> rangeForSpellChecking = 0;

I dont think the = 0 is needed, should be the default.