[webkit-reviews] review granted: [Bug 93937] Web Inspector: Calling getEventListeners() on element with malformed javascript event listeners crashes : [Attachment 158372] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 93937: Web Inspector: Calling getEventListeners() on element with malformed
javascript event listeners crashes
https://bugs.webkit.org/show_bug.cgi?id=93937

Attachment 158372: Patch
https://bugs.webkit.org/attachment.cgi?id=158372&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158372&action=review


> Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp:215
> +	       if (block.HasCaught() || function.IsEmpty())

I'd return upon HasCaught and assert non empty function.