[webkit-reviews] review granted: [Bug 93903] Crash in RenderTableCell::borderTop() due to custom scrollbars after r124168 : [Attachment 158124] Proposed fix: Added parent NULL-checks to detect detach tree conditions.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 13 18:22:06 PDT 2012


Tony Chang <tony at chromium.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 93903: Crash in RenderTableCell::borderTop() due to custom scrollbars after
r124168
https://bugs.webkit.org/show_bug.cgi?id=93903

Attachment 158124: Proposed fix: Added parent NULL-checks to detect detach tree
conditions.
https://bugs.webkit.org/attachment.cgi?id=158124&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158124&action=review


> Source/WebCore/ChangeLog:9
> +	   r124168 moved scrollbar creation from layout to styleDidChange.
Because the first styleDidChange
> +	   is called before we insert the new renderer into the tree, the code
has to be made aware of detached

Do we get a second styleDidChange after the new renderer is attached?


More information about the webkit-reviews mailing list