[webkit-reviews] review denied: [Bug 93802] Share common code between calendar picker and color suggestion picker : [Attachment 157939] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 93802: Share common code between calendar picker and color suggestion
picker
https://bugs.webkit.org/show_bug.cgi?id=93802

Attachment 157939: Patch
https://bugs.webkit.org/attachment.cgi?id=157939&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=157939&action=review


> Source/WebCore/ChangeLog:8
> +	   Moved common code between calandarPicker and colorSuggestionPicker
into pickerCommon.{js,css}

I recommend not addressing two things in one patch.  This patch can be split
into 1. Move files to Resources/pagepopup/ and 2. Sharing common code.

> Source/WebCore/ChangeLog:12
> +	   * Resources/pagepopup/calendarPicker.css: Renamed from
Source/WebCore/Resources/calendarPicker.css.

Probably Resources/pagepopups/ is better?

> Source/WebCore/ChangeLog:25
> +

We had better update ManualTests/forms/calendar-picker.html and
color-suggestion-picker.html.