[webkit-reviews] review denied: [Bug 93790] Improve test htmloutputelement.html : [Attachment 157916] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 93790: Improve test htmloutputelement.html
https://bugs.webkit.org/show_bug.cgi?id=93790

Attachment 157916: Patch
https://bugs.webkit.org/attachment.cgi?id=157916&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=157916&action=review


We had better move the test to fast/forms/output/, and split it to
 - fast/forms/output/output-type.html
 - fast/forms/output/output-value.html
 - fast/forms/output/output-for.html

> LayoutTests/fast/dom/HTMLOutputElement/htmloutputelement.html:31
> +// Check if name reflects attribute.
>  shouldBeEqualToString('output1.name', 'output1');
> +shouldBeEqualToString('output1.name = "bar"', 'bar');
> +shouldBeEqualToString('output1.name', 'bar');
> +shouldBeEqualToString('output1.getAttribute("name")', 'bar');
> +output1.setAttribute("name", "output1");
> +shouldBeEqualToString('output1.name', 'output1');

We should remove the test for name attribute because
fast/dom/domstring-attribute-reflection.html covers it.