[webkit-reviews] review granted: [Bug 93918] [Chromium] Patch CCThreadProxy to call setTimebaseAndInterval on CCScheduler : [Attachment 158173] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 13 17:59:45 PDT 2012


James Robinson <jamesr at chromium.org> has granted John Bates
<jbates at google.com>'s request for review:
Bug 93918: [Chromium] Patch CCThreadProxy to call setTimebaseAndInterval on
CCScheduler
https://bugs.webkit.org/show_bug.cgi?id=93918

Attachment 158173: Patch
https://bugs.webkit.org/attachment.cgi?id=158173&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158173&action=review


> Source/WebCore/platform/graphics/chromium/cc/CCFrameRateController.cpp:81
> +    TRACE_EVENT1("cc", "CCFrameRateController::setActive", "active",
active);

This seems unnecessarily spammy, can you put it below the early-out? When would
we want to know about redundant sets?


More information about the webkit-reviews mailing list