[webkit-reviews] review granted: [Bug 93513] Accumulating LayoutUnits with floats for determining block preferred width can lead to wrapping : [Attachment 157338] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Levi Weintraub <leviw at chromium.org>'s
request for review:
Bug 93513: Accumulating LayoutUnits with floats for determining block preferred
width can lead to wrapping
https://bugs.webkit.org/show_bug.cgi?id=93513

Attachment 157338: Patch
https://bugs.webkit.org/attachment.cgi?id=157338&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=157338&action=review


Looks fine.

> Source/WebCore/rendering/RenderBlock.cpp:3750
> +	   // FIXME: LayoutUnit::epsilon is probably only necessary here due to
lost precision elsewhere
> +	   while (logicalRightOffsetForLine(logicalTopOffset,
logicalRightOffset, false, &heightRemainingRight) - floatLogicalLeft +
LayoutUnit::epsilon() < floatLogicalWidth) {

How do we fix/track down this fixme?

> Source/WebCore/rendering/RenderBlock.cpp:3765
> +	   // FIXME: LayoutUnit::epsilon is probably only necessary here due to
lost precision elsewhere

Same question.	What's the plan for fixing this?