[webkit-reviews] review granted: [Bug 91769] Layout Test css3/filters/custom/custom-filter-animation.html is failing : [Attachment 157574] Patch V1

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Chiculita Alexandru
<achicu at adobe.com>'s request for review:
Bug 91769: Layout Test css3/filters/custom/custom-filter-animation.html is
failing
https://bugs.webkit.org/show_bug.cgi?id=91769

Attachment 157574: Patch V1
https://bugs.webkit.org/attachment.cgi?id=157574&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=157574&action=review


> Source/WebCore/ChangeLog:13
> +	   Also the GraphicsContext3D doesn't update it's own internal
m_boundFBO when a framebuffer is deleted,

typo it's -> its

> Source/WebCore/ChangeLog:17
> +	   The man for glDeleteFramebuffer says that the bound framebuffer is
unbound before deleting it.

I suggest "The documentation for glDeleteFramebuffer..."

> Source/WebCore/ChangeLog:20
> +	   and GraphicsContext3DEfl.cpp, to make sure that m_boundFBO is not
used for other purposes.

I think you left GraphicsContext3DEfl out of this patch. I'll r+ but cq- to
either fix that or this ChangeLog.