[webkit-reviews] review granted: [Bug 93456] [Microdata] HTMLPropertiesCollection does not contain all properties when item is not attached to the DOM tree : [Attachment 157165] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 8 11:11:35 PDT 2012


Ryosuke Niwa <rniwa at webkit.org> has granted Arko Saha <arko at motorola.com>'s
request for review:
Bug 93456: [Microdata] HTMLPropertiesCollection does not contain all properties
when item is not attached to the DOM tree
https://bugs.webkit.org/show_bug.cgi?id=93456

Attachment 157165: Patch
https://bugs.webkit.org/attachment.cgi?id=157165&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=157165&action=review


> Source/WebCore/dom/DynamicNodeList.cpp:45
> +	   Node* root = m_ownerNode.get();
> +	   while (Node* parent = root->parentNode())
> +	       root = parent;

Should we do this for labels node list and radio node list also?


More information about the webkit-reviews mailing list