[webkit-reviews] review granted: [Bug 90858] JSHeap and FastMallocStatistics based memory measurement for performance-tests : [Attachment 157145] proposed patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Zoltan Horvath
<zoltan at webkit.org>'s request for review:
Bug 90858: JSHeap and FastMallocStatistics based memory measurement for
performance-tests
https://bugs.webkit.org/show_bug.cgi?id=90858

Attachment 157145: proposed patch
https://bugs.webkit.org/attachment.cgi?id=157145&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=157145&action=review


> PerformanceTests/resources/runner.js:95
> +PerfTestRunner.printStatistics = function (statistics, description) {
>      this.log("");
> +    this.log(description);

We probably want to call this "title" or "label" instead of description because
there's a separate test-wide description we print.

> Tools/Scripts/webkitpy/performance_tests/perftest.py:157
> +	   self.output_statistics(test_name + ": JSHeap",
results[self._result_classes[1]], description_string)
> +	   self.output_statistics(test_name + ": FastMalloc",
results[self._result_classes[2]], description_string)

output_statistics will replace "/" by ": " so you can just use / here instead.