[webkit-reviews] review granted: [Bug 93262] [WK2][GTK] Improvements for the new spell-checking API : [Attachment 156680] Patch proposal

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 93262: [WK2][GTK] Improvements for the new spell-checking API
https://bugs.webkit.org/show_bug.cgi?id=93262

Attachment 156680: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=156680&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=156680&action=review


Please, check the comments I made here before landing, thanks!

> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:485
> +    if (!spellCheckingLanguages.length())

Use spellCheckingLanguages.isNull() instead.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:517
> +   
context->priv->textChecker->setSpellCheckingLanguages(CString(languages));

A char* can be assigned to a CString, so I'm not sure, but I think you can pass
the languages directly here:

context->priv->textChecker->setSpellCheckingLanguages(languages);