[webkit-reviews] review denied: [Bug 93252] Make GraphicsSurface double buffered by default. : [Attachment 156673] patch for feedback.

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Zeno Albisser
<zeno at webkit.org>'s request for review:
Bug 93252: Make GraphicsSurface double buffered by default.
https://bugs.webkit.org/show_bug.cgi?id=93252

Attachment 156673: patch for feedback.
https://bugs.webkit.org/attachment.cgi?id=156673&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=156673&action=review


Make sure this doesn't break WebGL on WebKit1.

> Source/WebCore/ChangeLog:9
> +	   two provide a front and a back buffer.

two -> to

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:267
> -    const QOpenGLContext* currentContext = QOpenGLContext::currentContext();

> -    QSurface* currentSurface = 0;
> -    if (currentContext != m_platformContext) {
> -	   currentSurface = currentContext->surface();
> +    if (QOpenGLContext::currentContext() != m_platformContext)
>	   m_platformContext->makeCurrent(m_surface);
> -    }
> +
>      blitMultisampleFramebuffer();
> -    if (currentSurface)
> -	  
const_cast<QOpenGLContext*>(currentContext)->makeCurrent(currentSurface);
> +    m_platformContext->makeCurrent(m_surface);

This will break WebGL on WebKit1.