[webkit-reviews] review granted: [Bug 93117] MediaStream API: Introduce RTCIceCandidate : [Attachment 156381] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 93117: MediaStream API: Introduce RTCIceCandidate
https://bugs.webkit.org/show_bug.cgi?id=93117

Attachment 156381: Patch
https://bugs.webkit.org/attachment.cgi?id=156381&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156381&action=review


> Source/WebCore/Modules/mediastream/DOMWindowMediaStream.idl:38
>	   attribute IceCandidateConstructor IceCandidate;
> +	   attribute RTCIceCandidateConstructor RTCIceCandidate;

It's kind of strange that we're rebuilding the entire feature with an RTC
prefix.  I guess we'll remove the non-RTC prefixed versions when the time is
right.

> Source/WebCore/Modules/mediastream/RTCIceCandidate.h:57
> +    String toString();

This function seems to be missing an implementation.

> Source/WebCore/Modules/mediastream/RTCIceCandidate.h:62
> +    RTCIceCandidate(PassRefPtr<RTCIceCandidateDescriptor>);

explicit