[webkit-reviews] review granted: [Bug 93119] MediaStream API: Introduce RTCSessionDescription : [Attachment 156379] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 93119: MediaStream API: Introduce RTCSessionDescription
https://bugs.webkit.org/show_bug.cgi?id=93119

Attachment 156379: Patch
https://bugs.webkit.org/attachment.cgi?id=156379&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156379&action=review


> Source/WebCore/Modules/mediastream/RTCSessionDescription.cpp:43
> +namespace {
> +
> +bool verifyType(const String& type)

Generally we prefer to use static functions rather than anonymous namespaces
(when possible).

> Source/WebCore/Modules/mediastream/RTCSessionDescription.h:58
> +    String toString();

I couldn't find the implementation of this function.

> Source/WebCore/Modules/mediastream/RTCSessionDescription.h:63
> +    RTCSessionDescription(PassRefPtr<RTCSessionDescriptionDescriptor>);

explicit