[webkit-reviews] review denied: [Bug 93059] [chromium] Refactor loops to guarantee 'updated' flag correctness. : [Attachment 156236] Patch

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has denied Eric Penner
<epenner at chromium.org>'s request for review:
Bug 93059: [chromium] Refactor loops to guarantee 'updated' flag correctness.
https://bugs.webkit.org/show_bug.cgi?id=93059

Attachment 156236: Patch
https://bugs.webkit.org/attachment.cgi?id=156236&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
Sorry to be grumpy about this, but TiledLayerChromium is already brittle and
overly complex and I don't want yet another flag.  I've seen too many bugs
where somebody forgets to set or unset some of these flags.  For example, you
don't set this flag to false in resetUpdateState, so it's stale on any tile
that got updated last frame but not this frame.  If somebody ever touches the
way these loops works, it seems possible that could bite them.	I point out
resetUpdateState not because I think fixing it will make this approach
palatable, but because I want to point out how easy it is to have a flag in a
wrong state unexpectedly.

Is it possible to not add another flag and instead push all the complexity into
the uncommon case of OOMing? Looping through all the tiles there and unsetting
the update flag seems like a much more simple solution.