[webkit-reviews] review denied: [Bug 91734] Web Inspector: native memory instrumentation: cover MemoryCache with MemoryInstrumentation : [Attachment 156392] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 91734: Web Inspector: native memory instrumentation: cover MemoryCache with
MemoryInstrumentation
https://bugs.webkit.org/show_bug.cgi?id=91734

Attachment 156392: Patch
https://bugs.webkit.org/attachment.cgi?id=156392&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156392&action=review


> Source/WebCore/dom/MemoryInstrumentation.h:108
> +    template <typename HashMapType> void addInstrumentedHashMap(const
HashMapType&, ObjectType, bool contentOnly = false);

Should we break this down into 
addHashMap
addInstrumentedValues
addInstrumentedKeys

> Source/WebCore/loader/cache/CachedCSSStyleSheet.cpp:201
> +    if (m_parsedStyleSheetCache)

info.addInstrumentedMember(m_parsedStyleSheetCache)

> Source/WebCore/loader/cache/CachedFont.cpp:213
> +    info.visitBaseClass<CachedResource>(this);

You're removing this method in another patch so would be nice to fix this.

> Source/WebCore/loader/cache/CachedResourceLoader.cpp:886
> +    info.addListHashSet(*m_preloads.get());

Just *m_preloads