[webkit-reviews] review granted: [Bug 92820] [chromium mac] DumpRenderTree compile fails with warning/error in LayoutTestHelper.mm with 10.7sdk : [Attachment 155724] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 3 00:06:29 PDT 2012


jochen at chromium.org has granted Nico Weber <thakis at chromium.org>'s request for
review:
Bug 92820: [chromium mac] DumpRenderTree compile fails with warning/error in
LayoutTestHelper.mm with 10.7sdk
https://bugs.webkit.org/show_bug.cgi?id=92820

Attachment 155724: Patch
https://bugs.webkit.org/attachment.cgi?id=155724&action=review

------- Additional Comments from jochen at chromium.org
Since you copied the code from the mac drt, should you add Apple to the
copyright line in the header?

View in context: https://bugs.webkit.org/attachment.cgi?id=155724&action=review


> Tools/DumpRenderTree/chromium/LayoutTestHelper.mm:44
> +    MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_7

this can all go on one line


More information about the webkit-reviews mailing list