[webkit-reviews] review granted: [Bug 92461] Fix null pointer dereference when CSSParser::sinkFloatingValueList() returns null and is passed to storeVariableDeclaration(). : [Attachment 154849] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 3 00:06:14 PDT 2012


Eric Seidel <eric at webkit.org> has granted Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 92461: Fix null pointer dereference when CSSParser::sinkFloatingValueList()
returns null and is passed to storeVariableDeclaration().
https://bugs.webkit.org/show_bug.cgi?id=92461

Attachment 154849: Patch
https://bugs.webkit.org/attachment.cgi?id=154849&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154849&action=review


> Source/WebCore/css/CSSParser.cpp:3019
> +    if (!value)
> +	   return;

A comment here to explain the "why" might be helpful.


More information about the webkit-reviews mailing list