[webkit-reviews] review denied: [Bug 92990] Web Inspector: Rename 'User agent' to 'Overrides' in settings screen : [Attachment 156088] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 2 10:59:01 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has denied Addy Osmani
<addyo at chromium.org>'s request for review:
Bug 92990: Web Inspector: Rename 'User agent' to 'Overrides' in settings screen
https://bugs.webkit.org/show_bug.cgi?id=92990

Attachment 156088: Patch
https://bugs.webkit.org/attachment.cgi?id=156088&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156088&action=review


> Source/WebCore/inspector/front-end/SettingsScreen.js:48
> +    this._tabbedPane.appendTab(WebInspector.SettingsScreen.Tabs.UserAgent,
WebInspector.UIString("Overrides"), new WebInspector.UserAgentSettingsTab());

You also need to chance these in the WebCore/English.lproj/localizedStrings.js


More information about the webkit-reviews mailing list