[webkit-reviews] review granted: [Bug 93009] Range::isPointInRange incorrectly throws WRONG_DOCUMENT_ERR : [Attachment 156122] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 2 10:54:55 PDT 2012
Ojan Vafai <ojan at chromium.org> has granted Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 93009: Range::isPointInRange incorrectly throws WRONG_DOCUMENT_ERR
https://bugs.webkit.org/show_bug.cgi?id=93009
Attachment 156122: Patch
https://bugs.webkit.org/attachment.cgi?id=156122&action=review
------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=156122&action=review
> LayoutTests/fast/html/range-point-in-range-for-different-documents.html:31
> + if (range.isPointInRange(testNode, 1))
> + testFailed('isPointInRange returned true.');
> + else
> + testPassed('isPointInRange returned false.');
Nit: this could be:
shouldBeFalse("range.isPointInRange(testNode, 1)")
More information about the webkit-reviews
mailing list