[webkit-reviews] review granted: [Bug 85139] MessagePort must set m_closed to be true at the end of MessagePort::close function : [Attachment 139368] Patch

Sat Apr 28 13:26:55 PDT 2012

Kentaro Hara <haraken at chromium.org> has granted Li Yin <li.yin at intel.com>'s
request for review:
Bug 85139: MessagePort must set m_closed to be true at the end of
MessagePort::close function
https://bugs.webkit.org/show_bug.cgi?id=85139

Attachment 139368: Patch
https://bugs.webkit.org/attachment.cgi?id=139368&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139368&action=review

>>> LayoutTests/fast/events/message-port-close.html:1
>>> +<body>
>> 
>> Nit: Shall we use a standard HTML format?
>> 
>> <!DOCTYPE html><html><head></head><body>...</body></html>
> 
> I am following the format of LayoutTests/fast/events/message-port-clone.html,
it seems that all of MessagePort related test cases used this format.

Makes sense.