[webkit-reviews] review granted: [Bug 85142] Clarified JSGlobalData (JavaScript VM) lifetime : [Attachment 139371] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 85142: Clarified JSGlobalData (JavaScript VM) lifetime
https://bugs.webkit.org/show_bug.cgi?id=85142

Attachment 139371: Patch
https://bugs.webkit.org/attachment.cgi?id=139371&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=139371&action=review


> Source/JavaScriptCore/ChangeLog:37
> +	   notwithstaning, C++ does in fact know how to execute destructors in 


Speling error, notwithstaning.

> Source/JavaScriptCore/runtime/JSGlobalData.h:155
> +	   Heap heap;

Could you add a comment here about the destruction order so nobody will
accidentally move this?