[webkit-reviews] review granted: [Bug 84566] Web Inspector: [chromium] show more useful information for throttled requests. : [Attachment 138916] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 28 00:31:08 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has granted yzshen at chromium.org's request
for review:
Bug 84566: Web Inspector: [chromium] show more useful information for throttled
requests.
https://bugs.webkit.org/show_bug.cgi?id=84566

Attachment 138916: Patch
https://bugs.webkit.org/attachment.cgi?id=138916&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138916&action=review


>>> LayoutTests/inspector/network-status-non-http.html:24
>>> +		     if (outputStatus.indexOf("(failed)") == 0)
>> 
>> Please use .startsWith for prefix checks.
> 
> Javascript string doesn't have .startsWith method, does it?

We added it to the String's prototype in utilities.js


More information about the webkit-reviews mailing list