[webkit-reviews] review denied: [Bug 84708] Web Inspector: Shortcuts screen UI polish : [Attachment 139019] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied eustas.bug at gmail.com's request
for review:
Bug 84708: Web Inspector: Shortcuts screen UI polish
https://bugs.webkit.org/show_bug.cgi?id=84708

Attachment 139019: Patch
https://bugs.webkit.org/attachment.cgi?id=139019&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139019&action=review


> Source/WebCore/inspector/front-end/KeyboardShortcut.js:64
> +    Left: { code: 37, name: "<Left>" },	     // also NUM_WEST

Even though they are not currently localized, they should be (at least Left,
Right, Up and Down)

> Source/WebCore/inspector/front-end/ShortcutsScreen.js:58
> +	* Renders sections to and appends them to the given node.

We don't comment on code in WebKit unless necessary.

> Source/WebCore/inspector/front-end/ShortcutsScreen.js:110
> +};

No ; after }

> Source/WebCore/inspector/front-end/helpScreen.css:132
> +    color: #DD0;

We try to use rgb() notation for colors.