[webkit-reviews] review denied: [Bug 84920] Add ASSERTs to avoid querying dirtied z-index or normal flow lists on RenderLayer : [Attachment 138920] Proposed change 1: added the ad-hoc ASSERTs.

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 84920: Add ASSERTs to avoid querying dirtied z-index or normal flow lists
on RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=84920

Attachment 138920: Proposed change 1: added the ad-hoc ASSERTs.
https://bugs.webkit.org/attachment.cgi?id=138920&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=138920&action=review


> Source/WebCore/rendering/RenderLayer.cpp:4176
> +    if (layer->isStackingContext()) {
> +	   if (Vector<RenderLayer*>* negZOrderList = layer->negZOrderList()) {

I'd prefer to not do this, and just ensure that non-stacking contexts have null
lists.