[webkit-reviews] review granted: [Bug 84940] Chromium Windows Perf bot timeouts due to no output : [Attachment 138966] Fixes the bug

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 84940: Chromium Windows Perf bot timeouts due to no output
https://bugs.webkit.org/show_bug.cgi?id=84940

Attachment 138966: Fixes the bug
https://bugs.webkit.org/attachment.cgi?id=138966&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138966&action=review


> Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:275
> +	       '', '']))

nit: you can use python's automatic string concatenation here and not have to
do the join, e.g.:
self.assertEquals(logs, ('Running (1 of 2)\n'
     'RESULT\n'
     'median\n')

and so forth. That style is much more common in our code for these multi-line
string constants.