[webkit-reviews] review granted: [Bug 84605] [chromium] Do not clobber synchronized start times. : [Attachment 138373] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted vollick at chromium.org's request
for review:
Bug 84605: [chromium] Do not clobber synchronized start times.
https://bugs.webkit.org/show_bug.cgi?id=84605

Attachment 138373: Patch
https://bugs.webkit.org/attachment.cgi?id=138373&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138373&action=review


Looks OK but try to get rid of the new member if you don't really need it.

> Source/WebCore/platform/graphics/chromium/cc/CCActiveAnimation.h:130
> +    bool m_hasSetStartTime;

we don't really need a bool, do we? m_startTime is initialized to 0 and can
only become non-zero by a setStartTime() call or code internal to
CCActiveAnimation, so would it be enough to just check for 0?